Conversation
blaiszik
reviewed
Jan 29, 2024
Contributor
blaiszik
left a comment
There was a problem hiding this comment.
Looks great, thanks for adding and updating tests as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem(s)
mkdiraction provider stopped creating parent dirs as neededApproach
This is not an ideal PR since so many things are wrapped up together.
Confirmation Email
In order to preview and debug the HTML, I put the template in a separate html file. The Flow script reads that file and includes in the flow definition.
The email includes a block that contains the citiation. This required generating string containing all of the author names. This is not possible as a flow expression so I added a new flow variable which keeps this handy.
Create SourceID directory
The files in the repo are kept in a subdirectory of a directory named after the submission's source ID. The subdirectory is for the version. Previously, the
mkdirActionProvider would create the entire path as needed. This stopped working recently. I added a new flow variable for the sourceID path and callmkdiron this first (telling it to ignore any errors from existing dirs) and then create the version subdirectory.Exception Handling
The flow was swallowing errors. I turned that off and tried to use the exception handler to send out an email. This was failing due to missing input parameters and some expression formatting mistakes in the flow