Skip to content

BSON made optional in emmet-core#530

Merged
munrojm merged 3 commits into
mainfrom
bugfix/bson_optional
Sep 9, 2022
Merged

BSON made optional in emmet-core#530
munrojm merged 3 commits into
mainfrom
bugfix/bson_optional

Conversation

@munrojm
Copy link
Copy Markdown
Member

@munrojm munrojm commented Sep 9, 2022

bson package made optional to allow for jsanitize util to be used with API client.

@munrojm munrojm added the release:patch Patch updates label Sep 9, 2022
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Sep 9, 2022

Codecov Report

Merging #530 (58cf778) into main (d62de3a) will decrease coverage by 0.02%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             main     #530      +/-   ##
==========================================
- Coverage   97.52%   97.49%   -0.03%     
==========================================
  Files         116       91      -25     
  Lines       24142    22023    -2119     
==========================================
- Hits        23544    21472    -2072     
+ Misses        598      551      -47     
Impacted Files Coverage Δ
emmet-core/emmet/core/utils.py 57.00% <50.00%> (-33.38%) ⬇️
emmet-core/emmet/core/oxidation_states.py 73.33% <0.00%> (-17.78%) ⬇️
emmet-core/emmet/core/qchem/molecule.py 80.18% <0.00%> (-16.99%) ⬇️
emmet-core/emmet/core/summary.py 80.00% <0.00%> (-10.38%) ⬇️
emmet-core/emmet/core/settings.py 88.52% <0.00%> (-9.84%) ⬇️
emmet-core/emmet/core/vasp/calc_types/utils.py 82.45% <0.00%> (-7.02%) ⬇️
emmet-core/emmet/core/molecules/atomic.py 93.15% <0.00%> (-2.74%) ⬇️
emmet-core/emmet/core/mpid.py 94.44% <0.00%> (-1.86%) ⬇️
emmet-core/emmet/core/molecules/bonds.py 80.72% <0.00%> (-1.81%) ⬇️
... and 28 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@munrojm munrojm merged commit 282b625 into main Sep 9, 2022
@munrojm munrojm deleted the bugfix/bson_optional branch September 9, 2022 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release:patch Patch updates

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants