Skip to content

Conversation

@Andrew-S-Rosen
Copy link
Member

@Andrew-S-Rosen Andrew-S-Rosen commented Nov 13, 2023

Addresses openjournals/joss-reviews#5995 (comment).

Namely, I previously used a minimal format for the Zenodo references. Now, I have used the one auto-generated by Zenodo. One downside of this approach is that the author list includes all contributors to the repo, no matter how large or small their contributions are.

I see two ways to go about this:

  1. Just accept it and move on.

  2. Keep the rest of the metadata but remove the author field.

@utf, any thoughts?

Addresses openjournals/joss-reviews#5995 (comment).

Namely, I used a minimal format for the Zenodo references. Now, I have used the one auto-generated by Zenodo. One downside of this approach is that the author list includes all contributors to the repo, no matter how large or small their contributions are.

I see two ways to go about this:

1) Just accept it and move on.

2) Keep the rest of the metadata but remove the `author` field.

@utf, any thoughts?
@codecov
Copy link

codecov bot commented Nov 13, 2023

Codecov Report

Merging #481 (66a67fd) into main (6f17f0b) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #481   +/-   ##
=======================================
  Coverage   99.86%   99.86%           
=======================================
  Files          20       20           
  Lines        1508     1508           
  Branches      415      415           
=======================================
  Hits         1506     1506           
  Misses          2        2           

@utf
Copy link
Member

utf commented Nov 13, 2023

Happy to just accept it!

@utf utf merged commit 1509c6c into materialsproject:main Nov 13, 2023
@Andrew-S-Rosen Andrew-S-Rosen deleted the patch-9 branch November 13, 2023 17:54
@utf utf added the docs Improvements or additions to documentation label Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants