-
Notifications
You must be signed in to change notification settings - Fork 31
Allow for MDCalc to be run with relax_cell=True during the initial relaxation
#96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Closes materialyzeai#95. Tests are still needed. Others are welcome to help with that if they feel so inclined; otherwise, I'll do so when I have a spare moment. Signed-off-by: Andrew S. Rosen <asrosen93@gmail.com>
Signed-off-by: Andrew S. Rosen <asrosen93@gmail.com>
RelaxCalc to be run with relax_cell=TrueRelaxCalc to be run with relax_cell=True
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #96 +/- ##
=======================================
Coverage 96.29% 96.29%
=======================================
Files 22 22
Lines 1160 1161 +1
=======================================
+ Hits 1117 1118 +1
Misses 43 43 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Andrew S. Rosen <asrosen93@gmail.com>
Signed-off-by: Andrew S. Rosen <asrosen93@gmail.com>
Signed-off-by: Andrew S. Rosen <asrosen93@gmail.com>
RelaxCalc to be run with relax_cell=TrueRelaxCalc to be run with relax_cell=True
RelaxCalc to be run with relax_cell=TrueMDCalc to be run with relax_cell=True
MDCalc to be run with relax_cell=TrueMDCalc to be run with relax_cell=True during the initial relaxation
|
@shyuep - This is ready for your review. |
|
@rul048 you are the maintainer. Pls review and merge. |
|
Thanks, will ping @rul048 if there is anything going forward. 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello Prof. Rosen. Thank you for your contribution. The initial reason we set relax_cell=False while only allowing users to optimize the atomic positions was to achieve the similar functionality of the minimize command in LAMMPS within MDCalc.
This approach ensures that the volume of the input structure remains exactly the same as the one used for the subsequent MD simulation, especially for NVT/NVE ensembles. However, it does limit flexibility for users who wish to perform NPT simulations with a fully optimized structure.
Thank you again for pointing this out in issue #95. Your method offers a flexible solution, and the implementation looks good to me.
|
@rul048: Thank you for reviewing this PR and for your detailed explanation of the history, which certainly makes a lot of sense. I greatly appreciate it! |
Closes #95 by making it possible to relax the unit cell before the MD run.