-
Notifications
You must be signed in to change notification settings - Fork 0
fix: Chore create buffers and binding groups #41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Chore create buffers and binding groups #41
Conversation
|
Caution Review failedFailed to post review comments. Configuration used: CodeRabbit UI ⛔ Files ignored due to path filters (22)
📒 Files selected for processing (25)
💤 Files with no reviewable changes (2)
🧰 Additional context used🧬 Code Graph Analysis (6)webpack.config.js (1)
integration-tests/index.ts (2)
src/WebGPU/programs/drawTriangle/getProgram.ts (3)
src/textures.ts (2)
integration-tests/tests/texture-urls.spec.ts (2)
src/WebGPU/pointer.ts (2)
🔇 Additional comments (50)
WalkthroughThis update refactors asset transformation utilities, texture handling, and WebGPU program initialization. Integration tests are restructured for precision and maintainability, including new tests for camera, resizing, and texture URLs. WebGPU programs now use external uniform buffers with bind group caching. Texture deduplication is based on pixel data, and asset map storage is optimized. The custom Zig loader is removed. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant PlaywrightTest
participant Utils
participant WebApp
participant GPU
participant ZigLogic
User->>PlaywrightTest: Run E2E test (e.g., resize, camera, texture upload)
PlaywrightTest->>Utils: Call utility (e.g., selectAsset, moveAsset)
Utils->>WebApp: Simulate pointer/mouse/keyboard events
WebApp->>GPU: Update canvas, trigger draw calls
WebApp->>ZigLogic: Update asset state, handle transformations
ZigLogic-->>WebApp: Return updated state
GPU-->>WebApp: Render frame
WebApp-->>PlaywrightTest: DOM/canvas updated, test assertions
sequenceDiagram
participant WebApp
participant Textures
participant GPU
participant Uploader
WebApp->>Textures: add(url, callback)
Textures->>Textures: Check for URL or pixel duplicate
alt New texture
Textures->>Uploader: uploadTexture(url, onNewUrl)
Uploader->>Textures: onNewUrl(newUrl)
Textures->>Textures: updateTextureUrl(textureId, newUrl)
end
Textures->>GPU: Create or reuse GPU texture
Textures-->>WebApp: callback(width, height, isNew)
Estimated code review effort🎯 5 (Critical) | ⏱️ ~70 minutes Possibly related PRs
Poem
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
npm error Exit handler never called! Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. ✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Summary by CodeRabbit
New Features
Improvements
Bug Fixes
Dependency Updates
zigar-loaderdevelopment dependency to version^0.14.1.Chores
.zigfiles to address known build issues.Refactor