Skip to content

matrix topology for all dimensions#1742

Merged
affeldt-aist merged 4 commits intomath-comp:masterfrom
zhou31416:fix_matrix_topology
Oct 31, 2025
Merged

matrix topology for all dimensions#1742
affeldt-aist merged 4 commits intomath-comp:masterfrom
zhou31416:fix_matrix_topology

Conversation

@zhou31416
Copy link
Copy Markdown
Contributor

Motivation for this change

PseudoMetricNormedZmodule (and so on) is only defined for matrices of dimension 'M_(m.+1, n.+1) rather than for all dimensions.

Currently, this restriction arises only from the local lemma ball_gt0, so it can be easily removed by redefining mx_ball as follows:
Definition mx_ball x e y := 0 < e /\ forall i j, ball (x i j) e (y i j).

Checklist

No additional lemmas or definitions added.
A minor modification of matrix_topology.v and matrix_normedtype.v
Generalize lemma rV_compact since it holds for all dimensions (rather than non-degenerative cases, i.e., 'M_(m.+1,n.+1).

Merge policy

As a rule of thumb:

  • PRs with several commits that make sense individually and that
    all compile are preferentially merged into master.
  • PRs with disorganized commits are very likely to be squash-rebased.
Reminder to reviewers

@proux01
Copy link
Copy Markdown
Collaborator

proux01 commented Oct 30, 2025

Copy link
Copy Markdown
Member

@CohenCyril CohenCyril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution. This is indeed a very welcome change!

Please fix the proof script: I submitted a (blind) fix, assuming you opened a new line with indentation for a subgoal, which must always be closed with a by / exact / other terminator as per mathcomp conventions. Please test my fix and ping me back.

Comment on lines +107 to +108
rewrite (_ : mkset _ = [set v0]).
apply: compact_set1.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
rewrite (_ : mkset _ = [set v0]).
apply: compact_set1.
rewrite (_ : mkset _ = [set v0]); first exact: compact_set1.

@zhou31416
Copy link
Copy Markdown
Contributor Author

Thanks for the suggestion; I’ve fixed it.
I also generalised mx_normZ to work with numDomainType rather than numFieldType.

@affeldt-aist affeldt-aist merged commit 33b3ec6 into math-comp:master Oct 31, 2025
46 checks passed
@zhou31416 zhou31416 deleted the fix_matrix_topology branch November 25, 2025 03:59
yosakaon pushed a commit to yosakaon/analysis that referenced this pull request Dec 4, 2025
* redefine mx_ball, NormedModule for matrices for all dimensions

* fix convention; generalize lemma mx_normZ
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants