matrix topology for all dimensions#1742
Merged
affeldt-aist merged 4 commits intomath-comp:masterfrom Oct 31, 2025
Merged
Conversation
Collaborator
|
FTR, this was discussed in #math-comp analysis > Matrix PseudoMetricNormedZmodule for all dimensions |
CohenCyril
requested changes
Oct 30, 2025
Member
There was a problem hiding this comment.
Thank you for your contribution. This is indeed a very welcome change!
Please fix the proof script: I submitted a (blind) fix, assuming you opened a new line with indentation for a subgoal, which must always be closed with a by / exact / other terminator as per mathcomp conventions. Please test my fix and ping me back.
Comment on lines
+107
to
+108
| rewrite (_ : mkset _ = [set v0]). | ||
| apply: compact_set1. |
Member
There was a problem hiding this comment.
Suggested change
| rewrite (_ : mkset _ = [set v0]). | |
| apply: compact_set1. | |
| rewrite (_ : mkset _ = [set v0]); first exact: compact_set1. |
Contributor
Author
|
Thanks for the suggestion; I’ve fixed it. |
CohenCyril
approved these changes
Oct 31, 2025
yosakaon
pushed a commit
to yosakaon/analysis
that referenced
this pull request
Dec 4, 2025
* redefine mx_ball, NormedModule for matrices for all dimensions * fix convention; generalize lemma mx_normZ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
PseudoMetricNormedZmodule (and so on) is only defined for matrices of dimension 'M_(m.+1, n.+1) rather than for all dimensions.
Currently, this restriction arises only from the local lemma ball_gt0, so it can be easily removed by redefining mx_ball as follows:
Definition mx_ball x e y := 0 < e /\ forall i j, ball (x i j) e (y i j).Checklist
No additional lemmas or definitions added.
A minor modification of matrix_topology.v and matrix_normedtype.v
Generalize lemma rV_compact since it holds for all dimensions (rather than non-degenerative cases, i.e.,
'M_(m.+1,n.+1).Merge policy
As a rule of thumb:
all compile are preferentially merged into master.
Reminder to reviewers