Skip to content

fix itvbc, etc. naming#1941

Merged
affeldt-aist merged 1 commit intomath-comp:masterfrom
affeldt-aist:fix_naming_20260418
Apr 21, 2026
Merged

fix itvbc, etc. naming#1941
affeldt-aist merged 1 commit intomath-comp:masterfrom
affeldt-aist:fix_naming_20260418

Conversation

@affeldt-aist
Copy link
Copy Markdown
Member

@affeldt-aist affeldt-aist commented Apr 18, 2026

Motivation for this change

This PR removes the deprecations on measurable_fun_itv_co and measurable_fun_itv_oc
and instead renames them following the naming convention from set_interval.v (PR 1935).

It also renames a couple of similarly-named lemmas.

Checklist
  • added corresponding entries in CHANGELOG_UNRELEASED.md
  • added corresponding documentation in the headers

Reference: How to document

Merge policy

As a rule of thumb:

  • PRs with several commits that make sense individually and that
    all compile are preferentially merged into master.
  • PRs with disorganized commits are very likely to be squash-rebased.
Reminder to reviewers

@affeldt-aist affeldt-aist added this to the 1.17.0 milestone Apr 18, 2026
@affeldt-aist affeldt-aist added the renaming/refactoring 🔧 This is about a renaming or refactoring in the library label Apr 18, 2026
@affeldt-aist affeldt-aist requested a review from t6s April 18, 2026 10:25
Copy link
Copy Markdown
Member

@t6s t6s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new names look more consistent and solid.

@affeldt-aist
Copy link
Copy Markdown
Member Author

Yes, it indeed feels better. Thanks for your time on Wednesday!

@affeldt-aist affeldt-aist merged commit e043b2a into math-comp:master Apr 21, 2026
50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

renaming/refactoring 🔧 This is about a renaming or refactoring in the library

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants