more uniform variable naming convention#314
Merged
CohenCyril merged 4 commits intomasterfrom Jan 26, 2021
Merged
Conversation
Member
|
I'd rather reuse the convetions from
Use
Use
Yes
Use the same sufix or prefix for the sets as their containing type (e.g.
or remove the suffix? (e.g.
|
Member
|
Member
|
Please rebase and then we merge |
- enforce the convention of using T, U for names of variables
in Type (or choiceType an pointedType)
+ as a consequence functions are of type T -> U
+ use I when the type corresponds to an index
- enforce the convention that sets are named A, B, C, D, etc.
+ indexed sets are rather named F
+ use X for set T and Y for set U when it makes sense when
we are talking about images/preimages
+ keep X for sets of pairs
- small reordering of lemmas in sections (basic_lemmas,
image_lemmas, bigop_lemmas) to take advantage of Implicit Types
- address comments by Cyril - document naming choices in the header - no more "ill-named" sets X or E or "ill-named" types U
bc182e7 to
60271d8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in Type (or choiceType an pointedType)
we are talking about images/preimages
image_lemmas, bigop_lemmas) to take advantage of Implicit Types