Skip to content

Generalize eqfun and eqrel to dependent functions#1300

Merged
CohenCyril merged 1 commit intomath-comp:masterfrom
Tragicus:eqfun
Feb 19, 2025
Merged

Generalize eqfun and eqrel to dependent functions#1300
CohenCyril merged 1 commit intomath-comp:masterfrom
Tragicus:eqfun

Conversation

@Tragicus
Copy link
Copy Markdown
Contributor

@Tragicus Tragicus commented Nov 27, 2024

Motivation for this change

Generalizes eqfun and eqrel to dependent functions (which will be useful when we will want and be able to put instances on dependent function types). This changes the implicit arguments of _ =2 _ since now, in (f =2 g) x y, x appears in the type of y.

Minimal TODO list
  • added corresponding entries in CHANGELOG_UNRELEASED.md
  • added corresponding documentation in the headers
  • tried to abide by the contribution guide
  • this PR contains an optimum number of meaningful commits

See this Checklist for details.

Overlays
Automatic note to reviewers

Read this Checklist.

@CohenCyril
Copy link
Copy Markdown
Member

You could add an Arguments directive to preserve the former implicits. I think in this particular case I'd rather put one _ to omit a redundant argument in the dependent case rather than use @ and put many _ in the non-dependent case...

@Tragicus
Copy link
Copy Markdown
Contributor Author

I can not access x to make it explicit without changing the type of eqrel _ _, which would break things very hard. rocq-prover/rocq#13435 seems to imply that this issue is by design (see also this Zulip thread)

@CohenCyril CohenCyril merged commit e7e8e07 into math-comp:master Feb 19, 2025
@Tragicus Tragicus deleted the eqfun branch February 21, 2025 08:32
@CohenCyril CohenCyril added this to the 2.4.0 milestone Apr 14, 2025
hoheinzollern pushed a commit to hoheinzollern/math-comp that referenced this pull request Feb 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants