Skip to content

[wip] port to HB#37

Merged
proux01 merged 3 commits intomasterfrom
hirarchy-builder
May 11, 2023
Merged

[wip] port to HB#37
proux01 merged 3 commits intomasterfrom
hirarchy-builder

Conversation

@gares
Copy link
Copy Markdown
Member

@gares gares commented Nov 9, 2021

It passes, there are mainly 3 problems:

  • the FO step of rewrite kicks in is a different way, and a few rewrite have to be made more precise
  • a perf problem with a hint extern declared in ssrnum
  • HB.pack is uber slow in a few cases

@gares
Copy link
Copy Markdown
Member Author

gares commented Nov 15, 2021

Help @CohenCyril for nix

@proux01
Copy link
Copy Markdown
Contributor

proux01 commented May 6, 2022

Here is a rebased branch: https://github.com/proux01/odd-order/tree/hierarchy-builder

@gares
Copy link
Copy Markdown
Member Author

gares commented May 6, 2022

you should be able to push to this branch now

@proux01 proux01 force-pushed the hirarchy-builder branch from 19cb234 to b6c749d Compare May 6, 2022 14:41
@proux01
Copy link
Copy Markdown
Contributor

proux01 commented May 6, 2022

Done (took me a while to figure out the name of the branch is hirarchy-builder without e 😢)

@gares
Copy link
Copy Markdown
Member Author

gares commented May 7, 2022

surely a typo from me, sorry

@proux01 proux01 force-pushed the hirarchy-builder branch 2 times, most recently from 895ea6f to 6569801 Compare January 25, 2023 22:54
@gares
Copy link
Copy Markdown
Member Author

gares commented Mar 7, 2023

Thanks apparently it was not that hard, but I got tired and missed a /= and thought it was a deep problem.

@proux01
Copy link
Copy Markdown
Contributor

proux01 commented Mar 8, 2023

Actually, the additional /= are less painful (except maybe when they require repeating a ! rewrite) than the (very few, only 5 instances here) associativity rewrite that require an additional pattern (but nothing specific to semirings here, we already experienced that with the HB port of mathcomp).

@proux01 proux01 force-pushed the hirarchy-builder branch from 50fa365 to cc43d70 Compare May 11, 2023 08:16
@proux01 proux01 marked this pull request as ready for review May 11, 2023 10:50
@proux01 proux01 merged commit fbf765f into master May 11, 2023
@proux01 proux01 deleted the hirarchy-builder branch May 11, 2023 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants