Skip to content

Fix "fm_open_in_explorer" in sidebar causes an exception#79

Merged
math2001 merged 3 commits intomath2001:masterfrom
jfcherng-sublime:fix/sidebar-exception
Mar 3, 2022
Merged

Fix "fm_open_in_explorer" in sidebar causes an exception#79
math2001 merged 3 commits intomath2001:masterfrom
jfcherng-sublime:fix/sidebar-exception

Conversation

@jfcherng
Copy link
Copy Markdown
Contributor

@jfcherng jfcherng commented Mar 3, 2022

In 74be57b, visible_on_platforms should be a optional arg. Otherwise, it's a BC breaking change for where visible_on_platforms is not specified such as sidebar or custom keybindings.


We need a new release to fix this since currently fm_open_in_explorer causes an exception right after you right click on the sidebar.

Traceback (most recent call last):
  File "D:\_Download\ST-SM\sublime_text_build_4129_x64\Lib\python38\sublime_plugin.py", line 1380, in is_visible_
    ret = self.is_visible()
TypeError: is_visible() missing 1 required positional argument: 'visible_on_platforms'

jfcherng added 3 commits March 3, 2022 14:28
"visible_on_platforms" should be a optional arg.

Signed-off-by: Jack Cherng <jfcherng@gmail.com>
Signed-off-by: Jack Cherng <jfcherng@gmail.com>
Signed-off-by: Jack Cherng <jfcherng@gmail.com>
@math2001 math2001 merged commit b98a222 into math2001:master Mar 3, 2022
@jfcherng jfcherng deleted the fix/sidebar-exception branch March 3, 2022 10:47
@math2001
Copy link
Copy Markdown
Owner

math2001 commented Mar 3, 2022

Thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants