feat(media): in-channel video streaming with embedded controls#7
Open
xogium wants to merge 1 commit into
Open
Conversation
Stream audio and video files from the connected-server view with embedded playback controls and a collapsible video panel for media-file streams. - Collapsible in-window video panel for local and remote media streams - Embedded player in the channel UI (play, pause, seek, broadcast gain) - Video file picker; optional system ffmpeg pre-conversion when the SDK cannot open a format (playback uses the SDK's bundled FFmpeg) Webcam transmission is out of scope for this client; patching the TeamTalk dylib is not acceptable. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Xogium sent me a video showing the video playing and it visually looks correct and functional. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ffmpegpre-conversion viaMediaTranscodeServicewhen the TeamTalk SDK cannot open a file format (playback itself uses the SDK's bundled FFmpeg)Out of scope: webcam video capture/transmission. The macOS TeamTalk 5 SDK uses 0RGB mode for camera capture, which fails on modern Mac hardware and cameras. Fixing that would require patching the SDK binary — something that feels extremely hackish and is deliberately not included in this PR.
Testing notes
I did what testing I could given that I am totally blind: keyboard navigation, VoiceOver announcements, control flow, and audio-side behavior. I have not been able to visually verify video rendering. Someone with some vision left should double-check the collapsible video panel for rendering glitches, layout issues, or other visual problems.
Test plan
ffmpegpre-conversion path works whenffmpegis installedmainMade with Cursor