Skip to content

Conversation

@FilippoOlivo
Copy link
Member

@FilippoOlivo FilippoOlivo commented Mar 10, 2025

This PR contains the documentation updated for 0.2 version:

  • Adaptive_function
  • Adaptive_functions
  • Condition
  • Data
  • Domain
  • Equation
  • Geometry
  • Loss
  • Model
  • Optim
  • Problem
  • Solver
  • Solvers
  • collector.py
  • graph.py
  • label_tensor.py
  • operator.py
  • operators.py
  • plotter.py
  • trainer.py
  • utils.py

@dario-coscia
Copy link
Collaborator

@FilippoOlivo can you restore at your first commit and then do an amend? Let's avoid to force push in this PR, so that we know we are not overriding files

@FilippoOlivo FilippoOlivo force-pushed the doc branch 2 times, most recently from aa0881b to fde6450 Compare March 11, 2025 15:44
@FilippoOlivo
Copy link
Member Author

I needed to force update due to a rebase with respect to upstream 0.2

@dario-coscia dario-coscia force-pushed the 0.2 branch 2 times, most recently from 1f54775 to 795e4a4 Compare March 12, 2025 18:40
@dario-coscia
Copy link
Collaborator

@FilippoOlivo @GiovanniCanali how are we with this?

@GiovanniCanali
Copy link
Collaborator

@FilippoOlivo @GiovanniCanali how are we with this?

Finishing the remaining docs. Should be done by today

@dario-coscia dario-coscia mentioned this pull request Mar 13, 2025
@FilippoOlivo FilippoOlivo force-pushed the 0.2 branch 3 times, most recently from 7eec394 to 795e4a4 Compare March 13, 2025 13:11
@dario-coscia dario-coscia force-pushed the doc branch 2 times, most recently from de5deb4 to 3f455b7 Compare March 13, 2025 19:43
@dario-coscia dario-coscia force-pushed the doc branch 2 times, most recently from 42a569c to af942ad Compare March 17, 2025 14:12
@dario-coscia dario-coscia marked this pull request as ready for review March 17, 2025 14:14
@dario-coscia
Copy link
Collaborator

@ndem0 This PR updates the documentation for the 0.2 version, can you review it as well?
Key updates:

  1. Update the documentation to be compliant with 0.2 version
  2. Introduce a workflow file that automatically generates .py and .html files from .ipynb in the tutorials folder.
  3. Updating the workflow files for building the doc and testing the doc

@dario-coscia dario-coscia added the pr-to-review Label for PR that are ready to been reviewed label Mar 17, 2025
pina/trainer.py Outdated
test_size=0.0,
val_size=0.0,
compile=None,
repeat=False,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe set it to None and override inside?

@FilippoOlivo
Copy link
Member Author

@dario-coscia @ndem0 before working on workflow I suggest to close this PR (if documentation part is ready). What do you think?

@dario-coscia
Copy link
Collaborator

Agree, for me it is ready for merge.

@FilippoOlivo
Copy link
Member Author

Ready also for me!

@GiovanniCanali
Copy link
Collaborator

Ready to merge!

@ndem0 ndem0 merged commit 15ac30b into 0.2 Mar 19, 2025
17 of 18 checks passed
@dario-coscia dario-coscia deleted the doc branch March 20, 2025 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation enhancement New feature or request high priority Higher priority pr-to-review Label for PR that are ready to been reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants