-
Notifications
You must be signed in to change notification settings - Fork 92
Fix python-version bug #682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix python-version bug #682
Conversation
Code Coverage SummaryResults for commit: 6935e0d Minimum allowed coverage is ♻️ This comment has been updated with latest results |
|
@dario-coscia @FilippoOlivo @ndem0 Issue #681 should be resolved, but it seems Python 3.14 is causing problems. All tests related to compilation for this version are failing, and there have been reports of Note: compilation is also responsible for #621. |
|
Maybe we need to change all workflows that have 3.10 in it and not '3.10'. Are there others? |
@dario-coscia As stated in the comment, this has been solved. However, the introduction of Python 3.14 has led to problems with |
We will solve it when #621 will be solved |
For now, I suggest to disable compilation also for python 3.14 |
|
@FilippoOlivo Yes, let's do this easy fix, in this PR is fine |
|
@GiovanniCanali can you find the torch issue? So that we can track it and revert the changes once solved by the torch team |
I will proceed as follows: first, I will disable Torch compilation for Python 3.14. At the same time, I will open a dedicated issue to document everything I find about it, since this is only a temporary fix. This will help ensure that we don’t lose track of the issue and can later implement a permanent solution once it’s available. |
b186360 to
2a0e866
Compare
|
@dario-coscia @FilippoOlivo @ndem0 I have tried several ways to bypass compilation, for instance in the trainer # Check if Python version is >= 3.14
if sys.version_info >= (3, 14):
compile = Falsebut tests fail anyway. Since this PR is devoted to solving an issue with the tutorial exported (solved!), I would merge this and open another PR for the compilation. For reference, see issue #683 |
Description
This PR fixes #681
Checklist