-
Notifications
You must be signed in to change notification settings - Fork 92
disable compilation py>=3.14 #690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
GiovanniCanali
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @dario-coscia,
I added minor comments regarding the Warning messages, please address them before merging.
pina/trainer.py
Outdated
|
|
||
| # checking compilation and automatic batching | ||
| if compile is None or sys.platform == "win32": | ||
| # compile disambled for windows and py>=3.14 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# Compilation disabled for Windows and for Python 3.14+
Code Coverage SummaryResults for commit: 52097f3 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Description
This PR fixes #ISSUE_NUMBER.
Checklist