Skip to content

Interface + base class for condition module#791

Merged
GiovanniCanali merged 3 commits intomathLab:0.3from
GiovanniCanali:condition_structure
Apr 23, 2026
Merged

Interface + base class for condition module#791
GiovanniCanali merged 3 commits intomathLab:0.3from
GiovanniCanali:condition_structure

Conversation

@GiovanniCanali
Copy link
Copy Markdown
Collaborator

Description

This PR fixes #790

In this PR, the following updates have been introduced:

  • condition module:
    • Improved and expanded documentation for clarity and usability
    • Extended test coverage
    • Moved data_manager.py and batch_manager.py to the new data/manager submodule
  • data/manager submodule:
    • Introduced a unified interface along with a factory class structure for data-manager related instances
    • Moved each data-manager type to its own file
    • Improved and expanded documentation for clarity and usability
    • Extended test coverage

The core logic underpinning the involved modules has remained unchanged from a user perspective.

Checklist

  • Code follows the project’s Code Style Guidelines
  • Tests have been added or updated
  • Documentation has been updated if necessary
  • Pull request is linked to an open issue

@GiovanniCanali GiovanniCanali requested a review from ndem0 April 23, 2026 09:00
@GiovanniCanali GiovanniCanali self-assigned this Apr 23, 2026
@GiovanniCanali GiovanniCanali added enhancement New feature or request pr-to-review Label for PR that are ready to been reviewed 0.3 Related to 0.3 release labels Apr 23, 2026
@GiovanniCanali GiovanniCanali marked this pull request as ready for review April 23, 2026 09:09
@GiovanniCanali GiovanniCanali requested review from a team and dario-coscia as code owners April 23, 2026 09:09
@GiovanniCanali GiovanniCanali merged commit fcaaedc into mathLab:0.3 Apr 23, 2026
2 of 19 checks passed
@GiovanniCanali GiovanniCanali deleted the condition_structure branch April 23, 2026 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0.3 Related to 0.3 release enhancement New feature or request pr-to-review Label for PR that are ready to been reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants