-
Notifications
You must be signed in to change notification settings - Fork 123
installation using Docker #96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
installation using Docker #96
Conversation
mtezzele
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not used to docker. Can you provide a simple "how to use it", please?
Moreover we have to figure out why the linux tests are failing...
| @@ -0,0 +1,2 @@ | |||
| ls | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this file necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No it is not necessary.
The only necessary is the Dockerfile in the two subfolder and the docker-exec.
dockerfiles/base/Dockerfile
Outdated
| # experience, namely; creating the user PyGeM, setting up the users | ||
| # environment and the default entry point and cmds. | ||
| # | ||
| # Authors: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the list of authors. We do not follow this style and github easily shows the author of each file.
dockerfiles/dev-env-base/Dockerfile
Outdated
| @@ -0,0 +1,50 @@ | |||
| # Author Davide Baroli <davide.baroli@uni.lu> | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the list of authors. We do not follow this style and github easily shows the author of each file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For style ok.
|
The dockerfile allows you to install a container with the environment and PyGeM as a virtual machine. So it aim is devote to distribute the code to everyone independently from the operator system of the local machine. It can be also used for installation on cluster.
|
|
Ok thank you very much. It is a very useful PR. There is still the author in dockerfiles/base/Dockerfile file. When you are able to fix docker with travis I will merge. If you need help just ask. |
|
It would be great if you could add the "how to use docker with pygem" in the readme file. |
|
I am adding the docker build and run in .travis.ylm. |
|
The travis compiles fine. But I am still pushing on docker.io the second container. |
|
What is the difference between the base container and the env-base? Remember to remove the author in the base file. In the travis file I think some code is replicated in the case of a linux machine. The docker image has everything we need to test the package right? So we do not have to install everything twice. Maybe an if statement for the osx case will fix it. Otherwise I just did not get docker entirely and I apologize :) If you add the how to in the readme I will merge (I think the section Dependencies and installation will fit the purpose). Thanks! |
|
Base container consists of : pulling phusion (light version of ubuntu 16.04) and set the permission to user PyGeM. |
|
Actually, it could be possible to simply let travis build the docker machine, use it to do the testing, and then once building the docker and testing have passed, deploy the newly built docker image to docker-hub. |
|
@DavideBaroliUniLu are you able to implement the suggestion of Luca? |
…rsion of sip since the default version selected by conda has incompatible api with qt4
|
I am running the deployment with dockerhub at "[https://hub.docker.com/r/pygemdocker/pygem/]".
|
|
I fixed 5 minutes ago the compatibility with the new version of python-occ. A rebase should fix it. |
* # This is a combination of 4 commits. # The first commit's message is: tests added for gui init # The 2nd commit message will be skipped: # tests added for gui init # The 3rd commit message will be skipped: # test for the main part of gui code # The 4th commit message will be skipped: # test for the main part of gui code * trying to solve conflicts * removed pillow from packages * removed pillow from travis installation
… it more general and fast
mathLab#87) changed the order of the points in the plot of bounding box
* More tests for radial and doc * one more test for beckert
* improved performance in freeform (~25%) * fixed bug and improved flexibility in unvhandler * new write comparison in unv tests
…/PyGeM into dbaroli/docker
|
I perform both rebase with squash. Now it is pretty better. |
|
I don't think you did. See here. You have to rebase with respect to the upstream/master. Ideally the rebase should has the following output: your branch (the yellow one) has to start from my last commit merged. Something like this should work: |
|
You have right. I get your point. |
|
The problem is that you have merged this branch with another one that is much older than yours. The rebase now produces conflicts. The ugly but effective way is to close this PR, then you have to open another PR with only one commit of the new files you added/edited in this PR. After this I will links the two PR in order to have some history. |
In this pull request, I create a docker container based on phusion image:0.9.19.
The docker-exec is use to launch the docker machine with X11 enable. For the structure of dockerfile separation I follow the FeNiCs one.
For any reference to docker, you can see "Containers for portable, productive and performant scientific computing" ([(http://arxiv.org/abs/1608.07573])