Detect if userid-socketid aren't connected in the database#587
Merged
John-Witter merged 4 commits intomainfrom Aug 29, 2022
Merged
Detect if userid-socketid aren't connected in the database#587John-Witter merged 4 commits intomainfrom
John-Witter merged 4 commits intomainfrom
Conversation
…ects Try to detect connection flutter by users
🎉 Detect if userid-socketid aren't connected in the database
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For whatever reason (networking glitches, etc.), occasionally a user would get into a state where they would be able to interact with a room, but they would not appear in the "Current Members" list. This happened because their socketId was not being recorded in the DB. This PR does the following:
When the user enters a room, the system ensures that their socketId is recorded in the DB
If a user finds that they are in this state (which shouldn't happen anymore because of the point above), selecting "Force Sync" will also fix the problem.
Also included are: