Skip to content

Detect if userid-socketid aren't connected in the database#587

Merged
John-Witter merged 4 commits intomainfrom
development
Aug 29, 2022
Merged

Detect if userid-socketid aren't connected in the database#587
John-Witter merged 4 commits intomainfrom
development

Conversation

@John-Witter
Copy link
Copy Markdown
Contributor

@John-Witter John-Witter commented Aug 29, 2022

For whatever reason (networking glitches, etc.), occasionally a user would get into a state where they would be able to interact with a room, but they would not appear in the "Current Members" list. This happened because their socketId was not being recorded in the DB. This PR does the following:

When the user enters a room, the system ensures that their socketId is recorded in the DB
If a user finds that they are in this state (which shouldn't happen anymore because of the point above), selecting "Force Sync" will also fix the problem.
Also included are:

  • some enhancements to server-side error messages surrounding this issue.
  • additional metrics for grafana to measure when users sockets disconnect multiple times

@John-Witter John-Witter merged commit d12fb7f into main Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants