Add support for dualScreen and add timer sync with config of presentation#11
Merged
Add support for dualScreen and add timer sync with config of presentation#11
Conversation
matheoleger
requested changes
Apr 10, 2023
index.ts
Outdated
| contextIsolation: true, | ||
| }, | ||
| }); | ||
| dual.loadURL("http://localhost:3000"); |
Owner
There was a problem hiding this comment.
Add like the main window :
if (app.isPackaged) {
win.loadFile("./build/index.html");
} else {
win.loadURL("http://localhost:3000");
}
index.ts
Outdated
| win.setFullScreen(false) | ||
| }) | ||
| win.setFullScreen(false); | ||
| dual?.close(); |
Owner
There was a problem hiding this comment.
There is an error when there is only one screen,
maybe a problem with this line ? Try to add a condition to know if dual is already null/close ?
src/components/Presentation.tsx
Outdated
| import { NavigationButton } from './NavigationButton'; | ||
| import { NavigationButton } from "./NavigationButton"; | ||
| import { SlideShow } from "../renderer/components/SlideShow"; | ||
| //TODO: Search for a way to import the css file from the presentation folder and display images with the folder temp |
matheoleger
approved these changes
Apr 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.