Skip to content

Fix/missing glob #1007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dpvc merged 1 commit into from
Sep 28, 2023
Merged

Fix/missing glob #1007

dpvc merged 1 commit into from
Sep 28, 2023

Conversation

@zorkow
Copy link
Member

@zorkow zorkow commented Sep 28, 2023

Adds the missing -g option for rimraf in the clean:lib script. Otherwise the lib directories are not removed recursively.

@zorkow zorkow requested a review from dpvc September 28, 2023 18:19
@zorkow zorkow changed the base branch from master to develop September 28, 2023 18:19
@dpvc
Copy link
Member

dpvc commented Sep 28, 2023

Looks good.

@dpvc dpvc merged commit 9ca7626 into develop Sep 28, 2023
@dpvc dpvc deleted the fix/missing_glob branch September 28, 2023 18:28
@dpvc dpvc added this to the v4.0 milestone Sep 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dpvc dpvc Awaiting requested review from dpvc

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v4.0

Development

Successfully merging this pull request may close these issues.

3 participants

@zorkow @dpvc