Feature/better honking #1054
Merged
Feature/better honking #1054
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One more PR. Fixes error in expressions that already contain an
maction(i.e., not one introduced bycollapsibleoption), wherevisitMactionNodecan introduce a second duplicatedata-maction-idattribute. This breaks XML parsing. Previously this was not an issue as we used HTML parsing, but now we are using SRE's XML parsing.Also some improvements to expansion/collapse/action:
Enterkey for action as this is what the aria tree pattern expects for triggering actions.