Tests cleanup after AllPackage removal. #1120
Merged
+1,724
−1,713
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpvc
approved these changes
Jul 10, 2024
Member
dpvc
left a comment
dpvc
left a comment
There was a problem hiding this comment.
Looks good. One question about backslashes, but not critical.
Comment on lines
315
to
353
| `<math xmlns=\"http://www.w3.org/1998/Math/MathML\" data-latex=\"\\begin{prooftree}\\AxiomC{A}\\LeftLabel{L}\\UnaryInfC{B}\\end{prooftree}\" display=\"block\"> | ||
| <mrow data-latex=\"\\begin{prooftree}\\AxiomC{A}\\LeftLabel{L}\\UnaryInfC{B}\\end{prooftree}\" data-latex-item=\"{prooftree}\" semantics=\"bspr_labelledRule:left;bspr_inference:1;bspr_proof:true\"> | ||
| <mpadded height=\".25em\" depth=\"+.25em\" width=\"+.5ex\" voffset=\"-.25em\" semantics=\"bspr_prooflabel:left\"> | ||
| <mstyle displaystyle=\"false\" scriptlevel=\"0\"> | ||
| <mtext>L</mtext> | ||
| </mstyle> | ||
| </mpadded> | ||
| <mtable align=\"top 2\" rowlines=\"solid\" framespacing=\"0 0\" semantics=\"bspr_inferenceRule:down\"> | ||
| <mtr> | ||
| <mtd> | ||
| <mtable framespacing=\"0 0\"> | ||
| <mtr> | ||
| <mtd rowalign=\"bottom\"> | ||
| <mrow data-latex=\"\\LeftLabel{L}\" semantics=\"bspr_axiom:true\"> | ||
| <mspace width=\".5ex\"></mspace> | ||
| <mstyle displaystyle=\"false\" scriptlevel=\"0\"> | ||
| <mtext>A</mtext> | ||
| </mstyle> | ||
| <mspace width=\".5ex\"></mspace> | ||
| </mrow> | ||
| </mtd> | ||
| </mtr> | ||
| </mtable> | ||
| </mtd> | ||
| </mtr> | ||
| <mtr> | ||
| <mtd> | ||
| <mrow> | ||
| <mspace width=\".5ex\"></mspace> | ||
| <mstyle displaystyle=\"false\" scriptlevel=\"0\"> | ||
| <mtext>B</mtext> | ||
| </mstyle> | ||
| <mspace width=\".5ex\"></mspace> | ||
| </mrow> | ||
| </mtd> | ||
| </mtr> | ||
| </mtable> | ||
| </mrow> | ||
| </math>` |
Member
There was a problem hiding this comment.
Are all the backslashes needed for the quotation marks? I guess they don't hurt, but they make the expected output a little harder to read.
Member
Author
There was a problem hiding this comment.
That comes from the little Emacs function that allows for copying received values from the test log.
And they actually do hurt, at least in the last three tests, where I had to manually copy things over from the test output as the slashed quotes ruined the tests.
I'll remove them and then merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR updates tests to work again after PR #1110 and #1115