Skip to content

Conversation

@dpvc
Copy link
Member

@dpvc dpvc commented Jul 30, 2025

This PR makes sure a component's lib directory is created so its main control file can be written, even if there are no other imports. This file contains the version check, and so it is useful to build even when there are no imports, or if all the imports are to other library files.

…e no imports (so the file containing the version check can still be made)
@dpvc dpvc requested a review from zorkow July 30, 2025 17:38
@dpvc dpvc added this to the v4.0 milestone Jul 30, 2025
@codecov
Copy link

codecov bot commented Jul 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.71%. Comparing base (e68c42f) to head (47c35fd).
⚠️ Report is 2 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1321   +/-   ##
========================================
  Coverage    86.71%   86.71%           
========================================
  Files          337      337           
  Lines        84074    84074           
  Branches      4758     4758           
========================================
  Hits         72904    72904           
+ Misses       11170    11147   -23     
- Partials         0       23   +23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@zorkow zorkow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@dpvc dpvc changed the title Make sure the buuild command makes the lib directory even if there are no imports Make sure the build command makes the lib directory even if there are no imports Aug 1, 2025
@dpvc dpvc merged commit dc661ff into develop Aug 1, 2025
3 checks passed
@dpvc dpvc deleted the fix/build branch August 1, 2025 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants