Skip to content

Conversation

@dpvc
Copy link
Member

@dpvc dpvc commented Oct 11, 2017

This PR adds a wrapper for the math tag that handles display math as a block-style element. It also adds support for percentage-width tables (which have to bubble the 100% percent width up through the parent elements to the containing math element). The TeX input uses percentage-width tables for the multline environment. You can also specify a fixed width for tables.

Copy link
Member

@zorkow zorkow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor things.

for (const child of this.childNodes) {
child.toCHTML(chtml);
if (child.bbox && child.bbox.w < 0) {
if (child.bbox.w < 0) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is child.bbox guaranteed to exist?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it is created in the Wrapper constructor at line 266

}

/*
* Handle the case where a child as a percentage width by
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

type: has

@dpvc dpvc merged commit 80d2275 into minor-fixes Jan 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants