Use 'overflow: clip visible' for stretchy characters to avoid unwanted clipping. (mathjax/MathJax#2701) #726
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d clipping in the non-stretching direction. (mathjax/MathJax#2701)
…maining rules (oops).
zorkow
approved these changes
Jun 12, 2021
Member
zorkow
left a comment
zorkow
left a comment
There was a problem hiding this comment.
Tested with a handful of browsers and worked fine everywhere except overline vanishes on IE 11 at 85% zoom. Otherwise fine on IE as well
I don't think that is a deal breaker, so I approve.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the overflow property used for the extenders in stretchy characters so that they clip only in the direction of the stretching. This avoid accidentally clipping thin horizontal and vertical lines, for example.
It also adds the index to the
insertRule()call in the HTMLadaptor so that it works in IE (which seems to require it), and wraps the call intry/catchso that rules that are only valid in modern browsers won't cause problems in IE (or other older browsers).Resolves issue mathjax/MathJax#2701.