Update version to beta.3 #974
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….js to webpack version that works like old __dirname did in webpack
zorkow
approved these changes
Jul 19, 2023
Member
zorkow
left a comment
zorkow
left a comment
There was a problem hiding this comment.
Please run npm install before merging, so package-lock.json will also be updated to beta.3.
Member
Author
|
Yes, I'm in the process of building the beta.3 font packages, and was going to update the package-lock.json after they are in place, but you beat me to it. Almost there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes several changes needed for version 4.0.0-beta.3. These fixes include:
require("mathjax")orimport "mathjax"or the same formathjax-full.mjs/root.jsin the webpacked combined configuration files with a newcomponents/root-pack.mjsthat does the same thing as__dirnamedoes in CommonJS webpacking (it replaces it with the directory/). This is not ideal, but it prevents the inclusion of the directory name where the webpacked file was created (e.g.,/home/travis/mathjax/MathJax-src/...). The v3 versions had a broken default directory in node as well, so this is no worse than in the past.