Fix in Distributions.Beta: avoid possible NaN caused by x==y==0 when a and b are both small#894
Merged
cdrnet merged 5 commits intomathnet:masterfrom Jan 24, 2022
Ebola-Chan-bot:master
Merged
Fix in Distributions.Beta: avoid possible NaN caused by x==y==0 when a and b are both small#894cdrnet merged 5 commits intomathnet:masterfrom Ebola-Chan-bot:master
cdrnet merged 5 commits intomathnet:masterfrom
Ebola-Chan-bot:master
Conversation
added 4 commits
January 7, 2022 14:27
This reverts commit 74470f9.
… b are both very small
Ebola-Chan-bot
changed the title
Ebola-Chan-bot
changed the title
Member
|
Thank you! We can bring this already into master/v5. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current master will possibly generate NaN when a and b are both small(<0.001). NaN is produced when x and y are accidentally both zero. We should regenerate the (x,y) pair when this happens.
We can't just apply a Bernoulli(p=0.5) to randomly give x or y a non-zero value, since they are only equally possible when a==b.