Fix for { fix for Superscript of tall expression (issue #763) }#779
Fix for { fix for Superscript of tall expression (issue #763) }#779kschaefe merged 2 commits intomathquill:masterfrom
Conversation
Fix to reflow properly superscript in cases of combo of sub+sup. Move reflow into SupSub so case a_b,right,^x is reflow-ed too. Use margin-bottom to lift superscript and dont touch vertical-align of mq-subsup (so rendering of subs is not messed).
|
Let's ensure that we add your visual tests to the visual tests page. This will help ensure that we don't lose the changes to a future regression. @laughinghan you can reflow another block, correct? I think that's what needed here. Any tips? |
Calculating needed lift-up by actually analyzing top of base and bottom of power and trying to align them properly.
|
I've changed the way I calculate needed lift-up for power (see 601946c ).
Result I get (I checked FF and Chrome, if you have mac/ie -- check it there too...): |
kschaefe
left a comment
There was a problem hiding this comment.
Can you please add your test case to the test/visual.html page?
|
You mean you want me to add |
|
@kschaefe ?? pls answer my previous comment. |
|
The work here fixes the misalignment @laughinghan noted after we merge #764. @laughinghan or @stufflebear I have pulled this down using command-line and have updated the visual.html page with @savthegood's monster LaTeX expression. Do you want me to push to a branch for either of you to review or merge into master? |
|
Hi guys - any update on this PR? |
|
#841 adds the visual checks for this request. Closing to use the new request. |
Dismissing my review because I will merge this. #841 has the requested fix and someone else can approve my change to get that fix in.
Fix for { fix for Superscript of tall expression (issue mathquill#763) }
Fixes mathquill#950 by reverting mathquill#764 and mathquill#779 Unfortunately, this leaves us back in a place where superscript and subscript placement isn't very good when they're attached to tall blocks, but I think if we're going to fix that, we need to find a way to do it that's more robust to continuing to edit the expression.
Fixes mathquill#950 by reverting mathquill#764 and mathquill#779 Unfortunately, this leaves us back in a place where superscript and subscript placement isn't very good when they're attached to tall blocks, but I think if we're going to fix that, we need to find a way to do it that's more robust to continuing to edit the expression.




Fix to reflow properly superscript in cases of combo of sub+sup. Move reflow into SupSub so case a_b,right,^x is reflow-ed too. Use margin-bottom to lift superscript and dont touch vertical-align of mq-subsup (so rendering of subs is not messed).