docs(design): formalize the heatmap has no legend by design (§7.6)#628
Merged
Conversation
Per maintainer decision on #617 (F-005): the dart-impact heatmap intentionally has no legend, density scale, or segment numbers — it is a qualitative overlay on a recognisable board, not a quantitative chart. DESIGN_SYSTEM §7.6 already implied this (it specs only the colormap/KDE); this makes the won't-fix explicit so future audits don't re-raise the missing legend. Closes #617. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Owner
Author
Code reviewNo issues found. Documentation-only amendment to DESIGN_SYSTEM §7.6, formalizing the maintainer's explicit decision that the heatmap has no legend by design (#617). No code changed. 🤖 Generated with Claude Code - If this code review was useful, please react with 👍. Otherwise, react with 👎. |
This was referenced Jun 20, 2026
mathrb
added a commit
that referenced
this pull request
Jun 25, 2026
* docs: link axis-5 findings to issues #612–#614 (closes #615) Update the individual F-NNN status lines in the pre-1.0 findings carnet to carry their issue + disposition, matching F-001's convention. The mapping already lived in the "Résolution" table; this propagates it down to each block. - F-021 (+F-007/F-008) → #612 Fixed (PR #624) - F-022 → #613 Won't-fix (nl already correct) - F-023/F-024/F-026 → #614 Fixed (PR #623) - F-025 → kept in carnet, à confirmer (no issue) - F-002 → #616 Fixed (PR #626); F-005 → #617 Won't-fix (PR #628) Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * docs: sync index-table rows with resolved finding statuses (#615) Self-review caught that the detail-block updates left the "## Index" quick- reference rows stale (still "confirmé") for the same findings, diverging from the F-001/F-020 convention of carrying the issue number in the index. Update the F-002/F-005/F-021/F-022/F-023/F-024/F-026 index rows to match. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#617 (F-005, P2)
The dart-impact heatmap has no legend/scale/segment numbers. DESIGN_SYSTEM §7.6 already documents only the colormap + KDE constants — it never required a legend, so the widget already matches the spec.
Per maintainer decision: amend the spec to make the won't-fix explicit (rather than adding a legend). The heatmap is a qualitative "where did my darts land" overlay on a recognisable board; the cold→hot ramp + the board's own geometry are the implicit reference, and a numeric scale/labels would clutter the at-a-glance read.
Doc-only change to §7.6. No code.
Closes #617.
🤖 Generated with Claude Code