fix(i18n): localize the auto-scoring settings page#718
Merged
Conversation
The #686 settings rework reintroduced ~20 hardcoded English strings on AutoScorerSettingsPage (record toggle, capture mode, export tile, clear dialog, detection thresholds), so the page rendered in English regardless of locale — on the exact screen testers use to enable recording and export sessions. Route every string through AppLocalizations with new autoScorer* keys, translated across all 7 locales. English values are kept byte-identical, so the existing widget test (default en locale) passes unchanged. Closes #717 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Owner
Author
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. 🤖 Generated with Claude Code - If this code review was useful, please react with 👍. Otherwise, react with 👎. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Routes every hardcoded English string on
AutoScorerSettingsPagethroughAppLocalizations, with 20 newautoScorer*keys translated across all 7 locales.Why
The whole app ships in 7 languages, but the #686 "streamlined settings" rework reintroduced ~20 raw
Text('…')literals on this page (record toggle, capture mode, export tile + progress, clear-data dialog, detection-thresholds section). The page rendered in English regardless of locale — on the exact screen we ask "conforming board" testers to use (enable recording → play → export sessions).Notes
app_en.arb) values are byte-identical to the old literals, so the existing widget test (defaultenlocale) passes unchanged.autoScorerExportProgress(pct)andautoScorerClearBody(frameCount, sessionCount)(ICU double-plural, replacing the manual?'':'s'pluralization).frreuses existing in-app darts terminology (cible / fléchettes).es/de/it/nl/pttranslated to match each locale's existing dartboard term (diana / Board / bersaglio / bord / alvo);ptfollows the file's Brazilian conventions (câmera / detecção).lib/l10n/gen/is gitignored (regenerates onpub get) — not committed.Verification
flutter gen-l10n+flutter analyze --no-fatal-infos→ clean project-wideflutter test .../auto_scorer_settings_page_test.dart→ 4/4 pass unchangedCloses #717
🤖 Generated with Claude Code