Use numeric inputs for all workout rep counters#116
Merged
rodrigogiraoserrao merged 1 commit intomainfrom Feb 17, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
<select>path with a unifiedcreateRepsInputhelper so both AMRAP and non-AMRAP sets use<input type="number">withstep="1"andinputMode="numeric".repOptionsgenerator and anyminconstraint so there is no template-enforced min/max on rep submission.Number.parseIntand setsetCustomValidityfor non-integers) while preserving prefill behavior from drafts/previous sessions.Testing
rg -n "createAmrapInput|repOptions\(" workout-session-logger.htmlwhich showed the unified input implementation and removal ofrepOptions, and the search completed successfully.python3 -m http.server 8000and loadedhttp://127.0.0.1:8000/workout-session-logger.htmlin a headless browser using Playwright to validate the UI, and a screenshot was captured successfully atartifacts/workout-session-logger-updated.png.Codex Task