feat: (Angular) template ref support#1157
Conversation
+ add template ref as type for components + track view ref for template based components + create view setup method (from template) + add test for template based component ~ check for html element when detecting if already renderer (init) ~ move component setup to own method ~ determine creation based of component type ~ clean up view based component - remove not required null suppression in test
- remove not required null suppression ~ use never instead of any for undefined cast - remove not used imports
+ add template ref as type in views, components and types ~ allow templates for all elements (components, tab, watermark, header)
~ apply formatting
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 1774e05:
|
|
@mathuo for the 'onlyWhenVisible' renderer to behave correctly, the angular renderer need callbacks on visibility change to correctly attach/detach the component. I need to do more test on how angular behave in all those cases but its best to have a separate PR for this. |
Nice! That last part may require exposing an event for the render mode as I don't believe one is currently exposed, for example this PR. Happy to merge this though - got quite a few changes sitting in the queue for the next major release but will make sure this is included. |
|
Glad to hear that. Your PR is exactly what i need to complete the implementation and fix a few unexpected behaviors. |
That PR is merged into master |
# Conflicts: # packages/dockview-angular/src/lib/dockview/dockview-angular.component.ts
~ create template based view in non-container related way ~ use unknown instead of any
…lar-template-ref-support
~ track component host view in viewRef ~ trigger change detection on viewref
~ always attach views on creation
|
Fixed the 'onlyWhenVisible' problem and updated for changes on master. I think its best to have the onShow/onHide improvements in a separate PR (which require some core adjustments). |
|
The initial onShow call for the ‘always’ renderer is missing but there is the onDidVisibilityChange event that might be better suited (but require some restructuring of the angular components factory). The onShow/onHide might end up to be very similar to the onDidVisibilityChange event - so i’m not sure if it is the right approach to extend, sorry for the additional work you had with this. I’m out for 2 weeks, so my evaluation have to wait for this time |
2 participants
Support angular templates for components.
Required to support property binding
(re-implement of #1101 without dependencies and reduced changes)