fix: enable tab group chip dragging in all animation modes and preser…#1160
Merged
fix: enable tab group chip dragging in all animation modes and preser…#1160
Conversation
…ve groups across moves Tab group chip dragging was broken in default (non-smooth) animation mode because _animState was never initialized, preventing dragover/drop from firing. Additionally, LocalSelectionTransfer was never set for chip drags, so other drop targets couldn't recognize the drag as internal. - Always initialize _animState and set LocalSelectionTransfer/PanelTransfer for chip drags regardless of animation mode - Set dataTransfer.effectAllowed and setData for react-dnd compatibility - Disable iframe pointer events during chip drag - Add tabGroupId to PanelTransfer so cross-group drops can distinguish tab group drags from full group drags - Add moveTabGroupToGroup to preserve tab group metadata (label, color, collapsed state) when moving a tab group to another group - Remove redundant drag class toggling from TabGroupChip (managed by Tabs) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 48b2822:
|
- TabGroupChip: verify dragstart no longer self-manages the dragging class - Tabs animation: 11 tests covering chip drag initialization in all modes, LocalSelectionTransfer setup, dataTransfer properties, collapse behavior, insertion index computation, transform skipping in default mode, cleanup on cancel, and drop handling in default mode - DockviewComponent: 4 tests covering moveGroupOrPanel with tabGroupId for center drops, collapsed state preservation, extremity drops creating new groups, and partial group moves leaving other panels in source Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ve groups across moves
Tab group chip dragging was broken in default (non-smooth) animation mode because _animState was never initialized, preventing dragover/drop from firing. Additionally, LocalSelectionTransfer was never set for chip drags, so other drop targets couldn't recognize the drag as internal.