fix: Vue defaultTabComponent and framework prop runtime updates#1188
Merged
fix: Vue defaultTabComponent and framework prop runtime updates#1188
Conversation
Pass defaultTabComponent to core options on mount and add watchers for all framework props (defaultTabComponent, watermarkComponent, rightHeaderActionsComponent, leftHeaderActionsComponent, prefixHeaderActionsComponent) so they update at runtime via updateOptions. Migrate dockview-vue tests from Jest to Vitest to enable proper SFC component mounting with @vue/test-utils. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…lity Vite 8 is ESM-only and cannot be loaded via require(). Adding "type": "module" to package.json and renaming CJS script to .cjs fixes the CI build. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
No longer used. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
mathuo
force-pushed
the
fix/vue-default-tab-component
branch
from
bd9b5fb to
d8e6678
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
default-tab-componentprop now works in the Vue integrationdefaultTabComponentto core options on mount so the core resolves the fallback tab namedefaultTabComponent,watermarkComponent,rightHeaderActionsComponent,leftHeaderActionsComponent,prefixHeaderActionsComponent) so they update at runtime viaupdateOptions, matching the React wrapper's behavior@vue/test-utilsTest plan
vitest runpasses all 72 tests across 6 filesdockview.spec.tsmounts the actualDockviewVueSFC and verifies prop changes triggerupdateOptionswith correct factory functionsvite buildsucceeds for dockview-vuedefault-tab-componenton<DockviewVue>and confirm custom tab renders🤖 Generated with Claude Code