chore: v6.0.0 release prep — docs, templates, Vue test fix#1209
Merged
chore: v6.0.0 release prep — docs, templates, Vue test fix#1209
Conversation
- Pin @vue/test-utils to 2.4.6 and vue to 3.4.21 via root resolutions to fix vitest TypeError (test-utils 2.4.10 calls app.onUnmount which requires Vue 3.5+, but yarn.lock pins Vue 3.4.21). - Add Vue test for tabGroupColors / tabGroupAccent reactive update path. - Document IContentRenderer onShow/onHide hooks in rendering.mdx. - Document overlay/popover behavior inside popout windows. - Add prose section in theming.mdx for tabAnimation, tabGroupIndicator, dndOverlayBorder, dndTabIndicator, edgeGroupCollapsedSize, colorScheme, and link the interactive theme builder. - Add Tab Groups + Edge Groups feature cards to homepage FEATURES list. - Add Vue, Angular, and vanilla TypeScript variants of the tab-groups template; advertise all four frameworks on the examples page. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
NX 22.7.1 ships with cliui 8.0.1 + wrap-ansi 7.0.0 as direct deps, so a fresh yarn install correctly nests wrap-ansi 7 (CJS) under cliui without needing the prior cliui/string-width override. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
- Add .nvmrc and bump engines.node to ^22.13.0 || >=24.0.0 (jsdom@29 in dockview-vue requires Node >= 20.19/22.13). - Pin typescript to ~5.4.0 so the lockfile resolves a version compatible with @angular/compiler-cli@17 (>=5.2 <5.5); the looser ^5.3.3 was hoisting 5.9.x and breaking dockview-angular's build. - Restore cliui/string-width resolution; nx run-many's CJS cliui bootstrap still needs string-width@4 alongside the v5 ESM copy. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
The vue and @vue/test-utils resolutions (added to pin away from a
broken @vue/test-utils@2.4.10) were forcing yarn 1 to hoist
string-width@5 (ESM) to top-level, which Node 24 doesn't auto-unwrap
when cliui's CJS bootstrap calls require('string-width'), so nx
run-many crashed with "s.stringWidth is not a function".
Without the pin, yarn now hoists string-width@4 (CJS) and Vue/test-
utils float to current versions where the TypeError no longer
reproduces.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
vue is only consumed by dockview-vue (peerDep) and its tests; pulling it up to root devDeps was the historical cause of the @vue/test-utils incompatibility that needed a yarn resolution to paper over. Letting dockview-vue own its own dev vue keeps version pressure local. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Type of change
Affected packages
dockview-coredockview(vanilla JS)dockview-reactdockview-vuedockview-angulardocsHow to test
Checklist
yarn lint:fixpassesyarn formatpassesnpm run genhas been run and generated files are up to dateyarn testpasses