fix: clear destination gap margin on cross-group chip drop (#1243)#1247
Merged
fix: clear destination gap margin on cross-group chip drop (#1243)#1247
Conversation
Cross-group tab-group drops delegated to moveGroupOrPanel without clearing the destination's dragover-applied gap margin. moveGroupOrPanel inserts new panels but does not recreate existing destination tabs, so the inline margin-left set by applyDragOverTransforms persisted as a visible gap next to the dropped group. The local-smooth path already called resetTabTransforms; the cross-group path now does the same. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cross-group tab-group drops delegated to moveGroupOrPanel without clearing the destination's dragover-applied gap margin. moveGroupOrPanel inserts new panels but does not recreate existing destination tabs, so the inline margin-left set by applyDragOverTransforms persisted as a visible gap next to the dropped group. The local-smooth path already called resetTabTransforms; the cross-group path now does the same.
Description
Type of change
Affected packages
dockview-coredockview(vanilla JS)dockview-reactdockview-vuedockview-angulardocsHow to test
Checklist
yarn lint:fixpassesyarn formatpassesnpm run genhas been run and generated files are up to dateyarn testpasses