fix(dockview-core): allow tab group chip drop on own group's edge (#1…#1248
Merged
fix(dockview-core): allow tab group chip drop on own group's edge (#1…#1248
Conversation
) The drop handler short-circuited any drop where panelId is null on the same group, which silently swallowed tab-group chip drops because they also have panelId === null (with tabGroupId set). Narrow the guard so only true full-group drags are blocked. Also fix moveTabGroupToGroup so an edge drop onto the source group cleans up the source when it becomes empty by comparing against the actual targetGroup (which may be a freshly created edge group) rather than the originally passed destinationGroup. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…242)
The drop handler short-circuited any drop where panelId is null on the same group, which silently swallowed tab-group chip drops because they also have panelId === null (with tabGroupId set). Narrow the guard so only true full-group drags are blocked. Also fix moveTabGroupToGroup so an edge drop onto the source group cleans up the source when it becomes empty by comparing against the actual targetGroup (which may be a freshly created edge group) rather than the originally passed destinationGroup.
Description
Type of change
Affected packages
dockview-coredockview(vanilla JS)dockview-reactdockview-vuedockview-angulardocsHow to test
Checklist
yarn lint:fixpassesyarn formatpassesnpm run genhas been run and generated files are up to dateyarn testpasses