chore(deps): upgrade vite toolchain (vite 7, plugin-vue 6, vue-tsc 3)#1269
Merged
Conversation
- vite 5 -> 7 (latest stable; fixes the latent "vitest 4 requires vite >=6" peer-dep mismatch) - @vitejs/plugin-vue 5 -> 6 - vue-tsc 2 -> 3 - @vue/tsconfig 0.5 -> 0.9 Drop `defineProps` / `defineEmits` imports from the four Vue SFCs: vue-tsc 3 now errors instead of warns on importing what are actually SFC compiler macros. The @vue/compiler-sfc warning has been telling us about this for a while. Only dockview-vue is exercised by these upgrades; the rest of the monorepo doesn't touch vite. Local build + 77 tests pass. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…toolchain # Conflicts: # package.json # packages/dockview-vue/package.json # yarn.lock
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
vite5 → 7 — also fixes a latent peer-dep mismatch wherevitest@4requiresvite >=6(we were running vitest 4 against vite 5)@vitejs/plugin-vue5 → 6vue-tsc2 → 3@vue/tsconfig0.5 → 0.9 — turns out to be a near no-op for us; the scaryverbatimModuleSyntax: trueis already on in 0.5defineProps/defineEmitsimports from the four Vue SFCs — vue-tsc 3 errors instead of warns on importing what are SFC compiler macros (Vue's compiler-sfc has been logging this warning for a while)Scope
Only
dockview-vueis exercised — no other package uses vite. The cleanup PR (#1268) hoistsvue-tsc,vitest,vue, etc. to root devDeps; this PR keeps them where they currently live on master so it can land independently. Will rebase if both end up in flight.Deferred
ng-packagr@21pinningtypescript >=5.9 <6.0)Test plan
yarn installcleanyarn build— all packages buildyarn test— 77 dockview-vue tests pass (+ all other packages)cd packages/docs && yarn build— docs site unchanged (doesn't use vite)🤖 Generated with Claude Code