chore(deps): upgrade gulp 4 -> 5#1270
Merged
Merged
Conversation
Only consumer is packages/dockview-core/gulpfile.js (SCSS -> CSS for dockview.css). gulp-dart-sass and gulp-concat have no peer-dep on a specific gulp version, so they're compatible as-is. Yarn lockfile shrinks substantially (~1500 lines) because gulp 5 replaces through2 with streamx and drops a long tail of legacy transitive deps. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
gulp-dart-sass has been effectively unmaintained since 2023 (still on through2, chalk@2), and it's the source of the Sass "legacy JS API" deprecation warnings — it calls the deprecated entry point internally. gulp-sass 6 is the actively maintained drop-in: same factory API and .logError handler, but it accepts the sass compiler as a constructor argument and uses Sass's modern JS API. Migration is one require-line change in packages/dockview-core/gulpfile.js. Verified: build:css succeeds with no legacy-JS-API warnings. (A separate @import-is-deprecated warning surfaces in theme/_space-mixin; that's an SCSS-source issue, not part of this swap.) Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
# Conflicts: # package.json # yarn.lock
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gulp4.0.2 → 5.0.1gulp-dart-sass(effectively abandoned since 2023, usesthrough2/chalk@2) withgulp-sass6 +sass1.99packages/dockview-core/gulpfile.jsgulpSass(),gulpSass.logError); the new plugin takes the sass compiler as a constructor arggulp-concatstays — last published 2017 but stable, no deprecation noise.Lockfile change
The
yarn.lockshrinks significantly because gulp 5 replacesthrough2withstreamxand drops a long tail of legacy transitive deps; the gulp-dart-sass → gulp-sass swap further reduces that surface.Remaining warning (not in scope)
After the swap, one Sass deprecation warning still surfaces during
build:css:That's a source-level issue (Sass
@importis being phased out in favor of@use), not a tooling issue. It was always being emitted but was drowned out by the JS-API warnings. Fix is a separate@import→@useSCSS refactor.Test plan
yarn installcleanyarn build— verifypackages/dockview-core/dist/styles/dockview.cssis produceddockview.cssagainst master — should be byte-identical (no compiler-output changes from the API-surface swap)🤖 Generated with Claude Code