added HTML reporting and updated pipeline to use latest orb-tools #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
davidbuzinski
commented
Apr 13, 2022
davidbuzinski
commented
- Added HTML test reporting and HTML test coverage
- Separated long commands to scripts in src/scripts to conform to CircleCI best practices
- Updated circleci/orb-tools version
- Updated pipeline to follow latest orb-tools template
mcafaro
approved these changes
Apr 13, 2022
🚀 Love the improvements.| @@ -0,0 +1,286 @@ | |||
| version: 2.1 | |||
| @@ -1,315 +1,36 @@ | |||
| version: 2.1 | |||
|
|
|||
| setup: true | |||
There was a problem hiding this comment.
New to me. Haven't used Circle's dynamic config yet.
| echo 'export PATH="'$rootdir'/bin:$PATH"' >> $BASH_ENV | ||
| environment: | ||
| PARAM_RELEASE: <<parameters.release>> | ||
| command: <<include(scripts/install.sh)>> |
There was a problem hiding this comment.
This is also new AFAIK and much better than having to do inline bash.
| build: | ||
| machine: | ||
| image: ubuntu-1604:201903-01 | ||
| image: ubuntu-2004:202111-02 |
There was a problem hiding this comment.
Yay! These examples have needed an update for some time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.