Implement parsing of lines with extended patch info#46
Merged
matiasb merged 2 commits intomatiasb:masterfrom Sep 12, 2017
volo-zyko:parse_patch_info_lines
Merged
Implement parsing of lines with extended patch info#46matiasb merged 2 commits intomatiasb:masterfrom volo-zyko:parse_patch_info_lines
matiasb merged 2 commits intomatiasb:masterfrom
volo-zyko:parse_patch_info_lines
Conversation
Beside that, make parsing a bit stricter, fix code for conversion to string in a number of places so that original and resulting diffs are the same now, add more tests.
Owner
|
Great! Thanks, and sorry for the delayed ack. Will take a look soon. |
Owner
|
Merged. Thanks a lot! 👍 |
Contributor
Author
|
Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now lines below are also parsed and added to
PatchedFileAdditionally unidiff now better parses empty lines within hunks (some editors may remove trailing spaces which is not a problem for GNU
patch)Also conversion to string now produces same diff as it was originally. This might be helpful for those who needs validating diffs/remove some irrelevant info/fix empty lines in hunks and save diff back to file.