-
Notifications
You must be signed in to change notification settings - Fork 0
Add test results summary and group logs #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
I'm only able to add 1 reviewer in this pull request, does anyone know why that might be the case? @sameagen-MW, can you review the pull request as well? |
| @@ -1 +1 @@ | |||
| # common-utils | |||
| # common-utils | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will this repo be public? Do you plan on adding some information to the README?
(A brief README example: https://github.com/matlab-actions/workflow-generator)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It will have to public since the rest of the project is open source. A README would probably be beneficial, although I don't see it as a super critical priority since the repo isn't intended for direct customer use (and that should be clear via context)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I don't mind deleting the README in its current form. If we want to keep it in the repo, then perhaps a sentence or two would be necessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The repo will indeed need to be public. I'm not sure what are the guidelines for a public repo.
I'm okay with removing the README as well if the guidelines don't have a strict requirement. Yeah, makes sense to add a few lines in the README if we need to keep it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mcafaro, do you think having a README is a requirement for this repo?
Huh, that's interesting. I haven't seen that before and am not sure why that would be the case. Sorry I missed this message before, I'm happy to also review the change |
sameagen-MW
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, although I didn't look super closely at all of the files which were just copied over with no other changes.
I do notice that there's a message in the actions run which might indicate that the plugins aren't getting packaged correctly, here:
https://github.com/matlab-actions/common-utils/actions/runs/19126939215/job/54658903185?pr=1#step:4:34
Could you check up on that to make sure that it's not an issue? Other than that, looks ready to go!
| @@ -0,0 +1,31 @@ | |||
| // Copyright 2020-2025 The MathWorks, Inc. | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know whether these copyrights should be changed to just 2025 or not. These are all fresh files, but the code has been moved from somewhere else so it seems murky.
Do you know the right practice here @mcafaro?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm still not a fan of the integration testing style approach where we have to use test data to cover all branches and code paths. It also causes us to keep basically 3 copies of any test data file we make for each platform. The code changes look good though.
Summary
This PR includes:
Details
This feature creates an in-platform summary for MATLAB test results if the user has a MATLAB Test license. Subsequent changes in other actions-repo will follow.
Key highlights:
P.S. These utility functions would be utilized in run-command, run-tests and run-build actions to the generate test results summary
Some additional changes:
Old:

New:
