fix: resolve config file path against GITHUB_WORKSPACE#29
Merged
Conversation
Previously used __dirname which pointed to the action's own dist/ directory, so the config file was never found in the consuming repo. Closes #28 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
✅🙏🏻 Conventional Commit 🥳 🎉🤖 Beep boop! Congrats, it like all your commit messages conform to the Conventional Commit spec! 👏👏👏 Your PR can be closed. Coffee is for closers, so here's a coffee for you: ☕️ Commit Message Lint Report
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
config_pathinput resolving to the action's owndist/directory instead of the consuming repo's workspacepath.join(__dirname, '/../', configPath)withpath.join(process.env.GITHUB_WORKSPACE || process.cwd(), configPath)Closes #26
Root cause
__dirnameinsidedist/index.jspoints to the action's install path (e.g.…/_actions/matmar10/prcolinter/v1/dist). Going one level up still lands inside the action bundle, not the checked-out consumer repo.GITHUB_WORKSPACEis the correct root.Test plan
.github/prcolinterrc.jsonwith at least one rule override and verify the rule takes effectGITHUB_WORKSPACE{}→ only default rules apply)🤖 Generated with Claude Code