[Bug] Goal based on visit duration does not always get triggered even if visit duration > trigger time

[peterbo]

What happened?

Goal based on visit duration does not always get triggered even if visit duration > trigger time:

In this case, Heartbeat measures the time on the single action.

What should happen?

Visit duration based Goal should fire reliably, even if visit duration is only a ping and user has only 1 Action

How can this be reproduced?

• Create visit duration based goal,
• visit a single page in a fresh session
• even if Heartbeat works (see screenshots above) and measures a visit duration, goal may not be fired

Matomo version

5.3.1

PHP version

8.x

Server operating system

No response

What browsers are you seeing the problem on?

No response

Computer operating system

No response

Relevant log output

Validations

• Read our Contributing Guidelines.
• Follow our Security Policy.
• Check that there isn't already an issue that reports the same bug to avoid creating duplicates.
• The provided steps to reproduce is a minimal reproducible of the Bug.

[sgiehl]

Looks like a duplicate of #23165

[sgiehl]

But I guess the problem is somewhere around the ping request handling. Looks like it currently unsets all goal conversions on purpose:

matomo/plugins/Heartbeat/Tracker/PingRequestProcessor.php

Lines 26 to 39 in 9a3ef94

	if ($this->isPingRequest($request)) {
	// on a ping request that is received before the standard visit length, we just update the visit time w/o adding a new action
	Common::printDebug("-> ping=1 request: we do not track a new action nor a new visit nor any goal.");
	$request->setMetadata('Actions', 'action', null);
	$request->setMetadata('Goals', 'goalsConverted', array());
	$request->setMetadata('Goals', 'visitIsConverted', false);
	// When a ping request is received more than 30 min after the last request/ping,
	// we choose not to create a new visit.
	if ($request->getMetadata('CoreHome', 'isNewVisit')) {
	Common::printDebug("-> ping=1 request: we do _not_ create a new visit.");
	return true; // abort request
	}
	}

[peterbo]

Hey @sgiehl - I'm guilty of not checking for duplicates. Apologies! ;)

Looks like it currently unsets all goal conversions on purpose:

Yep, that's my impression as well. Would be great to have this, because measuring modern engagement rate often includes visit duration (i.e. active for >15s, visitor counts as engaged).