Add caching to two Archive loader methods #23216
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michalkleiner
force-pushed
the
dev-18869
branch
from
f41c9bd to
87b4088
Compare
michalkleiner
added
Enhancement
sgiehl
previously requested changes
Apr 11, 2025
Member
sgiehl
left a comment
sgiehl
left a comment
There was a problem hiding this comment.
There are still a couple of tests failing. So for now I've only done a high level code only review. I did not yet test anything
…ing if lower period has visits
mneudert
requested changes
Apr 29, 2025
Contributor
Author
|
@mneudert review feedback addressed |
mneudert
approved these changes
Apr 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Please include a description of this change and which issue it fixes. If no issue exists yet please include context and what problem it solves.
Review