Skip to content

Further improve annotation generation#10

Merged
snake14 merged 7 commits into
5.x-devfrom
PG-4502-improving-annotations
Sep 22, 2025
Merged

Further improve annotation generation#10
snake14 merged 7 commits into
5.x-devfrom
PG-4502-improving-annotations

Conversation

@snake14
Copy link
Copy Markdown
Contributor

@snake14 snake14 commented Sep 21, 2025

Description

This is making some more improvements to the annotation generator, including adding to the very limited test coverage.

Issue No

PG-4502

Steps to Replicate the Issue

  1. Check out the branch
  2. Generate annotations for a plugin, like CustomDimensions.
  3. Generate a spec file for the plugin.
  4. Preview the generated spec file using the SwaggerUI preview mode in PHPStorm

Checklist

  • [✔] Tested locally or on demo2/demo3?
  • [✔] New test case added/updated?
  • [NA] Are all newly added texts included via translation?
  • [NA] Are text sanitized properly? (Eg use of v-text v/s v-html for vue)
  • [✖] Version bumped?

@snake14 snake14 marked this pull request as ready for review September 22, 2025 11:11
@snake14 snake14 added the Needs Review For pull requests that need a code review. label Sep 22, 2025
@snake14 snake14 requested a review from a team September 22, 2025 11:12
Copy link
Copy Markdown
Contributor

@AltamashShaikh AltamashShaikh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@snake14
Copy link
Copy Markdown
Contributor Author

snake14 commented Sep 22, 2025

Thank you for the review @AltamashShaikh . Apologies for the large PR.

@snake14 snake14 merged commit 5bcff25 into 5.x-dev Sep 22, 2025
10 of 11 checks passed
@snake14 snake14 deleted the PG-4502-improving-annotations branch September 22, 2025 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs Review For pull requests that need a code review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants