Upgrade dependencies, scope, and downgrade to match minimum PHP#13
Conversation
|
Apologies for accidentally tagging you for review @matomo-org/core-reviewers . Please disregard this PR. |
james-hill-matomo
left a comment
There was a problem hiding this comment.
While testing, I tried generating annotations for the Whitelabel plugin, and it didn't work for me. I wouldn't worry too much about this at this stage, but thought it was worth mentioning.
jms@WI-LIN-ENG-JH-1:~/dev/matomo_5x-dev/plugins/OpenApiDocs$ ddev matomo:console plugin:activate WhiteLabel
The plugin WhiteLabel is already activated.
jms@WI-LIN-ENG-JH-1:~/dev/matomo_5x-dev/plugins/OpenApiDocs$ ddev matomo:console openapidocs:generate-annotations --plugin=plugin-Whitelabel
Generating annotations for: plugin-Whitelabel
ERROR [2025-10-02 00:38:06] 43971 Uncaught exception: /core/Plugin/Manager.php(304): The plugin plugin-Whitelabel is not enabled. You can activate the plugin on Settings > Plugins page in Matomo.
#0 /plugins/OpenApiDocs/Annotations/AnnotationGenerator.php(108): Piwik\Plugin\Manager->checkIsPluginActivated('plugin-Whitelab...')
Other than that, tested working OK in both PHP 7.2 and 8.2.
Thank you :)
@james-hill-matomo I guess the messaging could be improved, but it's likely because the Whitelabel plugin doesn't define an API class. |
Description
Upgrading, scoping, and transpiling dependencies (Rector downgraded them to be PHP 7.3 compatible). There were no manual changes in the vendor/ directory, and if you ignore that directory, only 7 files were altered.
Issue No
PG-4540
Steps to Replicate the Issue
ddev matomo:console openapidocs:generate-annotations --plugin=CustomReports --not-dry-runddev matomo:console openapidocs:generate-spec-file --plugin=CustomReports --not-dry-runChecklist