Add the phpDocumentor dependency#15
Merged
Merged
Conversation
* Make code change after dependency update * Making a few more adjustments to switch dependencies * Try adding bootstrap to alias classes for PHPStan * Try some changes * Revert "Try some changes" This reverts commit 43b085b. * Revert "Try adding bootstrap to alias classes for PHPStan" This reverts commit 1626077. * Adding autoload to test file * Trying simplified bootstrap for PHPStan
|
Huh, I guess it's smart enough to not need re-approval... nice |
Contributor
Author
@james-hill-matomo Possibly. I'm not sure if the auto-invalidation of previous approvals is working right for this repo. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Switch from using Matomo dependency to scoped dependency for parsing docblocks. This only covers the composer and scoping changes.
The only manual change for this PR was adding the dependency to the composer.json file. Everything else was done by composer and the scoping/rector scripts. The next PR contains the manual changes to use the new dependency.