Test adding PHPCS check to the pre-push hook

[snake14]

Description

Testing out adding the PHPCS check to the pre-push check. To test a failure, I simply made a copy of the pre-push file, named it pre-commit, and moved a curly brace in another file to the same line as the method signature.

[snake14]

@james-hill-matomo @AltamashShaikh I mentioned that I used the pre-commit hook to test this change and now I'm thinking that maybe I should simply commit that and leave pre-push as it was. I could even change it to run PHPCBF to automatically fix any issues before commit. What do you think?

[AltamashShaikh]

@james-hill-matomo @AltamashShaikh I mentioned that I used the pre-commit hook to test this change and now I'm thinking that maybe I should simply commit that and leave pre-push as it was. I could even change it to run PHPCBF to automatically fix any issues before commit. What do you think?

Makes sense 👍

[snake14]

@AltamashShaikh @james-hill-matomo Please check the latest changes and let me know if everything looks good.

[james-hill-matomo]

pre-commit hook is great if it runs quickly.

[james-hill-matomo]

@snake14 this doesn't run on my PC as I don't have PHP locally, just via ddev.

I can work on this later to work on my setup.

[snake14]

@snake14 this doesn't run on my PC as I don't have PHP locally, just via ddev.

I can work on this later to work on my setup.

@james-hill-matomo I wonder if it's as simple and using ddev exec if DDEV is running. I can try making that change in a little while.

[james-hill-matomo]

@snake14 this doesn't run on my PC as I don't have PHP locally, just via ddev.
I can work on this later to work on my setup.

@james-hill-matomo I wonder if it's as simple and using ddev exec if DDEV is running. I can try making that change in a little while.

@snake14 Also have to change the paths. This manual test worked for me:

ddev exec phpcbf plugins/OpenApiDocs --standard=plugins/OpenApiDocs/phpcs.xml

You can see the pre-push checks for PHP, although they're pretty straight forwards.

[AltamashShaikh]

Works fine for me, just need to check with ddev

[snake14]

@AltamashShaikh @james-hill-matomo I'm pretty sure that I've got it working for both local PHP and DDEV now. I also updated to stop if PHPCBF finds anything to correct. I thought about auto-adding, but figured that it would be better to have the dev review and add manually.

[AltamashShaikh]

Still works fine for me 👍

[snake14]

@james-hill-matomo Please review/test again and let me know if there are any issues.

[james-hill-matomo]

Works for me now, thank you!