Plugin whitelist now uses file system, #PG-5137

[lachiebol]

Description

Third party plugins will now be discovered and supported.

Event added that we will hook into with cloud plugin to add extra non-activated plugins.

Can see what gets pulled through the whitelist now with this method: index.php?module=API&method=OpenApiDocs.getPluginWhitelist&format=JSON&token_auth=anonymous

Issue No

Steps to Replicate the Issue

Checklist

• [✔] Tested locally or on demo2/demo3?
• [✔] New test case added/updated?
• [NA] Are all newly added texts included via translation?
• [NA] Are text sanitized properly? (Eg use of v-text v/s v-html for vue)
• [NA] Version bumped?
• [NA] Documentation updated?

[lachiebol]

@AltamashShaikh From codex, but this is intended behaviour from us.

• 1. Blocking: Generation/PluginListProvider.php:43 regresses the default plugin set by filtering out any installed plugin that is not currently activated (isPluginActivated at lines 66-69). Before this branch, both API.php:33 and Tasks.php:53 ultimately
     used config/plugins.php:3, which included many plugins regardless of activation state. The new tests even codify that event-added inactive plugins should be kept in the result (tests/Unit/Generation/PluginListProviderTest.php:112), so the activation
     gate is inconsistent with the branch’s own intended behavior. In practice this means previously supported installed plugins like AbTesting, TagManager, LoginSaml, etc. disappear from getPluginWhitelist() and from scheduled generation as soon as they
     are deactivated, which is a behavior regression unrelated to third-party support.

[AltamashShaikh]

@lachiebol Why don't we do something like this ?

$pluginNames = $this->pluginManager->getActivatedPlugins();
Piwik.postEvent('OpenApiDocs.filterActivePlugins', [&$pluginNames]);

Later Cloud code will remove, below plugins and add other if needed

  public const PLUGIN_BLOCKLIST = ['Billing', 'Cloud', 'ConnectAccounts', 'CDN', 'ProxySite'];

[lachiebol]

I'll just use the updatePluginList hook in Cloud.php to handle this, I'll update that PR

[lachiebol]

Wasn't aware of getActivatedPlugins(), much better :)

[AltamashShaikh]

The Cloud plugin list should not be part of this code now, as we were not going to release this plugin earlier.

[AltamashShaikh]

Note: We should also inform to keep the task setting disabled by default on Cloud and should be enabled only for demo.matomo.cloud

[lachiebol]

Note: We should also inform to keep the task setting disabled by default on Cloud and should be enabled only for demo.matomo.cloud

@AltamashShaikh It's off by default at the moment, what options do we have to automatically enable for on prem?

[AltamashShaikh]

Note: We should also inform to keep the task setting disabled by default on Cloud and should be enabled only for demo.matomo.cloud

@AltamashShaikh It's off by default at the moment, what options do we have to automatically enable for on prem?

@lachiebol Is should be on by default!

[AltamashShaikh]

LGTM 👍